[FIXED] Hebrew kerning problem: can't drag and drop letters to kern

Post your bug reports here. Include information that helps us to understand and reproduce the bug.
Post Reply
Hafonton
Posts: 88
Joined: Wed Aug 29, 2018 2:22 pm

[FIXED] Hebrew kerning problem: can't drag and drop letters to kern

Post by Hafonton »

Problem: When you use the dragging option to kern two letters in hebrew (drag the first letter - lamed-hebr - the one on the right - to make it closer to shin-hebr), it only changes XAdvance, therefore changing the distance between the letter before the pair and the pair itself (that's not the intended kerning).

Solution: When kerning a pair using the dragging tool while "Right to left" is checked, it should change the XPlacement to be equal as XAdvance at all times.

Description:
Until now I did this manually every time for every pair (change XPlacement to equel as XAdbance) and it takes so much time, because I need to change both inputs for each pair I kern. I thought maybe if I'd share this you could fix it and drop the kerning duration by at least 50% for right to left users. I'd really appreciate that.
The problem was there ever since I first started using FontCreator, but I never thought to address this until today. :shock:

OS and FC version: I use the FontCreator 13.0.0.2613, windows 10.

How to reproduce:
1. Download the attached font
2. Write this in the OpenType dDsigner: משולש
3. Try to play drag and drop the letter lamed-hebr and you'll see it only updates XAdvance when it should update both XAdvance and XPlacement.

Image

If you could do this, I bet all your right-to-left users will really appreciate it.
Thanks
Attachments
FtMelutash-0.47-Bold - reproduce hebrew kerning problem.fcp
(5.34 KiB) Downloaded 69 times
Erwin Denissen
Moderator
Moderator
Posts: 9333
Joined: Fri Oct 04, 2002 12:41 am
Location: Bilthoven, The Netherlands
Contact:

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Erwin Denissen »

This sounds like something we can easily implement.

Allow a couple of days to further look into this.
Erwin Denissen
High-Logic
Proven Font Technology
Hafonton
Posts: 88
Joined: Wed Aug 29, 2018 2:22 pm

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Hafonton »

That would be wonderful! :o
looking forward to it.
Hafonton
Posts: 88
Joined: Wed Aug 29, 2018 2:22 pm

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Hafonton »

Thanks for taking the time to fix this in FontCreator Version 12.0.0.2621!
It works perfectly.
Hafonton
Posts: 88
Joined: Wed Aug 29, 2018 2:22 pm

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Hafonton »

Hey Erwin,
I found another problem that need to be fixed regarding to this topic.
When scrolling up/down to increase/decrease the values of XAdvance or XPlacement (while Right To Left is on), the values should match at all times.

Image

Thanks
Erwin Denissen
Moderator
Moderator
Posts: 9333
Joined: Fri Oct 04, 2002 12:41 am
Location: Bilthoven, The Netherlands
Contact:

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Erwin Denissen »

I've further simplified the user interface. In general the pair adjustment will now look like this:
basickerning.png
basickerning.png (57.2 KiB) Viewed 2215 times
I wonder if the order of the class names (second, first) in the list box is as you would expect it? We once thought this was logical, but maybe it isn't :lol:
Erwin Denissen
High-Logic
Proven Font Technology
Hafonton
Posts: 88
Joined: Wed Aug 29, 2018 2:22 pm

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Hafonton »

Wow that's a wonderful simplify! I love it.
I'm not sure if the right-to-left was turned on in your screenshot,
but as a reference, this is the current way:
(this kerns these two letters: ז־)
Image
Erwin Denissen
Moderator
Moderator
Posts: 9333
Joined: Fri Oct 04, 2002 12:41 am
Location: Bilthoven, The Netherlands
Contact:

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Erwin Denissen »

Yes, it is RTL.

I will upload another update soon.
Erwin Denissen
High-Logic
Proven Font Technology
Hafonton
Posts: 88
Joined: Wed Aug 29, 2018 2:22 pm

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Hafonton »

Looking forward to it!
Erwin Denissen
Moderator
Moderator
Posts: 9333
Joined: Fri Oct 04, 2002 12:41 am
Location: Bilthoven, The Netherlands
Contact:

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Erwin Denissen »

Here is the update.

It has minor improvements to the shaping engine, the proofing tool, and kerning.

FontCreatorSetup version 13.0.0.2625 (x64)

Let us know your results, so we can officially release it.
Erwin Denissen
High-Logic
Proven Font Technology
Bhikkhu Pesala
Top Typographer
Top Typographer
Posts: 9113
Joined: Tue Oct 29, 2002 5:28 am
Location: Seven Kings, London UK
Contact:

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Bhikkhu Pesala »

I like the new simplified kerning dialog.

I cannot understand the OpenType proofing dialog at all, though I have not really tried much.

I read the Help topic, but it hides behind the FontCreator window as soon as I select the dialog, which is not so helpful.

I have the FontCreator glyph overview on my primary monitor and the OpenType Designer on my secondary monitor. F1 does not work from the OT Proofing window, but the Help button in the OT Designer window still works.
OpenType Laout Feature Proofing.png
OpenType Laout Feature Proofing.png (19.84 KiB) Viewed 2132 times
My FontsReviews: MainTypeFont CreatorHelpFC13 Pro + MT10.0 @ Win10 2004 build 19041.867
Erwin Denissen
Moderator
Moderator
Posts: 9333
Joined: Fri Oct 04, 2002 12:41 am
Location: Bilthoven, The Netherlands
Contact:

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Erwin Denissen »

Within the Proofing window I mostly inspect the treeview and click the items, so I can further investigate specific actions. Sometimes I click in the preview, to limit the number of actions.

https://www.high-logic.com/font-editor/ ... -unleashed

Proofing is great to understand what actions are performed, especially when contextual actions are applied.

We will make the Proofing tool even more powerful, if more functionality is needed. For example more detailed information for each output glyph, like final movement, type (mark, base, or ligature).
Erwin Denissen
High-Logic
Proven Font Technology
Hafonton
Posts: 88
Joined: Wed Aug 29, 2018 2:22 pm

Re: Hebrew kerning problem: can't drag and drop letters to kern

Post by Hafonton »

Erwin Denissen wrote: Thu Apr 09, 2020 9:14 pm Here is the update.

It has minor improvements to the shaping engine, the proofing tool, and kerning.

FontCreatorSetup version 13.0.0.2625 (x64)

Let us know your results, so we can officially release it.
What's the shaping engine?

I saw the new fun changes in the kerning, here's my result:
(the input works, but the letter is not draggable anymore like before)
Image
Post Reply